BADFUNC.PATH.SHELLEXECUTE : Use of ShellExecute

JavaScript is not currently enabled, but is required for full CodeSonar manual search and browse functionality.

If you are viewing this file in your hub's Web GUI, enable JavaScript in your browser: you will also need it for GUI functionality.

If you opened this file directly from disk, your browser may be directly suppressing JavaScript functionality: certain browsers perform this suppression on local files (but not files delivered by web servers) for security reasons.

If you access the manual through the hub's Web GUI, the functionality will not be suppressed because the hub is a web server.
Alternatively, your browser may allow you to explicitly disable the security setting that suppresses functionality. See the CodeSonar FAQ for more information.

A use of ShellExecute() or ShellExecuteEx(), which are vulnerable to path spoofing if the file name argument is not securely specified.

Class Name

Use of ShellExecute

Significance

security

Mnemonic

BADFUNC.PATH.SHELLEXECUTE

Categories

CWE	CWE:676	Use of Potentially Dangerous Function
DISA-3r10	DISA-3r10:V-6157	The designer will ensure the application does not contain invalid URL or path references.
BSI	BSI:ShellExecute	Use of ShellExecute

Availability

Available for C and C++.

Enabling

Checks for this warning class are disabled by default. To enable them, add the following WARNING_FILTER rule to the project configuration file.

WARNING_FILTER += allow class="Use of ShellExecute"

To enable all BSI-related classes, including all BSI-specific BADFUNC classes, use the bsi configuration preset.

HINSTANCE

ShellExecute(

HWND hwnd,
LPCTSTR lpOperation,
LPCTSTR lpFile,
LPCTSTR lpParameters,
LPCTSTR lpDirectory,
INT nShowCmd)

BOOL

ShellExecuteEx(LPSHELLEXECUTEINFO lpExecInfo)

For uses of ShellExecute(), make sure that the lpFile and lpDirectory parameters are fully-specified path names from a trusted sources, and that the lpFile value includes a file extension. Additionally, if there is any white space in the lpParameters string make sure it is correctly double-quoted.

For uses of ShellExecuteEx(), the lpFile, lpParameters and lpDirectory values are encapsulated in lpExecInfo, but the same concerns apply.

Once you are satisfied that these conditions hold, you can change the warning state to Suppressed.

To include an additional function or set of functions in the checks for this class, create a new set of BAD_FUNCTION_* rules in which the BAD_FUNCTION_REGEX setting matches the function or set of functions you want to check and the remaining rules match those in the other sets for this class.

To remove a function or set of functions from the checks for this class, edit the configuration file to comment out the corresponding set of BAD_FUNCTION_* rules.

The following configuration file parameters affect checks for this warning class.

BADFUNC.PATH.SHELLEXECUTE : Use of ShellExecute

Summary

Properties

Resolution

Relevant Configuration File Parameters

HINSTANCE	ShellExecute( HWND hwnd, LPCTSTR lpOperation, LPCTSTR lpFile, LPCTSTR lpParameters, LPCTSTR lpDirectory, INT nShowCmd)
BOOL	ShellExecuteEx(LPSHELLEXECUTEINFO lpExecInfo)