JavaScript is not currently enabled, but is required for full CodeSonar manual search and browse functionality.
If you are viewing this file in your hub's Web GUI, enable JavaScript in your browser: you will also need it for GUI functionality.
If you opened this file directly from disk, your browser may be directly suppressing JavaScript functionality: certain browsers perform this suppression on local files (but not files delivered by web servers) for security reasons.
| CodeSonar® 9.0p0 Hot Tips | CONFIDENTIAL | CodeSecure Inc |
The code contains type-testing that should not be used.
| Class Name | Inappropriate Instanceof (C#) | |||
|---|---|---|---|---|
| Significance | reliability | |||
| Mnemonic | CSHARP.CLASS.IOF.BAD | |||
| Categories |
|
|||
| Availability | Available for C# only. |
|||
| Enabling | Checks for this warning class are enabled by
default. To disable them, add the following WARNING_FILTER rule to the
project configuration file.
WARNING_FILTER += discard class="Inappropriate Instanceof (C#)" |
Japanese (ja)
public class MyClass
{
public string s
public override boolean Equals(Object obj)
{
if(obj != null )
if (obj is string) // "Inappropriate Instanceof (C#)" warning issued here
// - expect instance check inside MyClass.Equals() to check MyClass (or a subclass of MyClass, if any)
return s.equals(obj);
return false;
}
}
In this example, the programmer should modify the Equals as follows:
public override boolean Equals(Object obj)
{
if(obj != null )
if (obj is MyClass)
return s.equals(((MyClass) obj).s);
return false;
}
Check if the is operator can be actually removed and that it is not the sign of an actual programming bug.
The following configuration file parameters affect checks for this warning class.