JavaScript is not currently enabled, but is required for full CodeSonar manual search and browse functionality.
If you are viewing this file in your hub's Web GUI, enable JavaScript in your browser: you will also need it for GUI functionality.
If you opened this file directly from disk, your browser may be directly suppressing JavaScript functionality: certain browsers perform this suppression on local files (but not files delivered by web servers) for security reasons.
| CodeSonar® 9.0p0 Hot Tips | CONFIDENTIAL | CodeSecure Inc |
The code contains an instanceof test that should not be used.
| Class Name | Inappropriate Instanceof (Java) | |||
|---|---|---|---|---|
| Significance | reliability | |||
| Mnemonic | JAVA.CLASS.IOF.BAD | |||
| Categories |
|
|||
| Availability | Available for Java only. |
|||
| Enabling | Checks for this warning class are enabled by
default. To disable them, add the following WARNING_FILTER rule to the
project configuration file.
WARNING_FILTER += discard class="Inappropriate Instanceof (Java)" |
Consider the following program:
Japanese (ja)
public class Foo {
public String s
@Override
public boolean equals(Object obj) {
if(obj != null)
if (obj instanceof String) /* "Inappropriate Instanceof (Java)" warning issued here
* - should only check for Foo or a class derived from Foo.
*/
return s.equals(obj);
return false;
}
}
In this example, the programmer should modify equals() as follows.
@Override
public boolean equals(Object obj) {
if(obj != null)
if (obj instanceof Foo)
return s.equals(((Foo) obj).s);
return false;
}
Check if the instanceof operator can be actually removed and that it is not the sign of an actual programming bug.
The following configuration file parameters affect checks for this warning class.