Java


JAVA.CLASS.MCS : Missing Call to super (Java)

Summary

A call to super() is missing.

Java allows methods to call their implementation in the superclass, through the super.m(pars) syntax. It is sometimes the case that redefinitions are expected to call their implementation in the superclass. This checker identifies situations where a call to super.m(pars) seems to have been forgotten.

Properties

Class Name Missing Call to super (Java)
Significance reliability
Mnemonic JAVA.CLASS.MCS
Categories
CWE CWE:103 Struts: Incomplete validate() Method Definition
  CWE:568 finalize() Method Without super.finalize()
  CWE:573 Improper Following of Specification by Caller
  CWE:580 clone() Method Without super.clone()
CERT-Java CERT-Java:MET53-J Ensure that the clone() method calls super.clone()
Availability Available for Java only.
Enabling Checks for this warning class are enabled by default. To disable them, add the following WARNING_FILTER rule to the project configuration file.
WARNING_FILTER += discard class="Missing Call to super (Java)"

Example

public class TestSuper implements Cloneable {
// TestSuper.java
  private final long time = System.currentTimeMillis();

  public void m() {}

  public long getTime() {
    return time;
  }

  @Override
  protected Object clone() {
      return this;  /* "Missing Call to super (Java)" warning issued here
                     * - expect a call to super.clone()
                     */
  }
}
// A.java
public class A extends TestSuper {

  @Override
  public void m() {
      super.m();
  }
}
// B.java
public class B extends TestSuper {

  @Override
  public void m() {
      super.m();
  }
}
// C.java
public class C extends TestSuper {

  @Override
  public void m() {
      super.m();
  }
}
// D.java
public class D extends TestSuper {

  @Override
  public void m() {
  }                 /* "Missing Call to super (Java)" warning issued here
                     * - the three other subclasses of TestSuper call super.m()
                     *   in their redefinitions of m().
                     */
  }

Resolution

Check if a call to super.m(pars) has been forgotten and add it consequently.

Relevant Configuration File Parameters

The following configuration file parameters affect checks for this warning class.