C and C++


LANG.STRUCT.SE.ASSIGN : Too Many Side Effects in Assignment

Summary

An assignment operation has two or more additional side effects (beyond the side effect of the assignment itself).

Properties

Class Name Too Many Side Effects in Assignment
Significance style
Mnemonic LANG.STRUCT.SE.ASSIGN
Categories
JSF++ JSF++:204 A single operation with side-effects shall only be used in certain contexts.
JPL JPL:19 Do not use expressions with side effects.
Availability Available for C and C++.
Enabling Checks for this warning class are disabled by default, and require the unnormalized C ASTs for the project. To enable them, add the following WARNING_FILTER rule and RETAIN_UNNORMALIZED_C_AST specification to the project configuration file.
RETAIN_UNNORMALIZED_C_AST = Yes
WARNING_FILTER += allow class="Too Many Side Effects in Assignment"
Note that retaining the unnormalized ASTs will increase the disk space used to store the project representation, and may make the analysis take longer.

Example

extern int x, y;

extern int f(int);            /* Functions are assumed to have side effects unless
                               * SIDE_EFFECT_FREE_FUNCTIONS specifies otherwise */
extern int iArr[10];

void assignment_rhs(void){
    x += f(x);                                  /* only one additional side effect */
    y = x+=2;                                   /* only one additional side effect */
    iArr[x++]=f(y);      /* 'Too Many Side Effects in Assignment' warning issued here
                          * - 2 additional side effects */
    y *= (x++ + y++);    /* 'Too Many Side Effects in Assignment' warning issued here
                          * - 2 additional side effects */
    x = (x+=2) * (y-=3); /* 'Too Many Side Effects in Assignment' warning issued here
                          * - 2 additional side effects */
}

Relevant Configuration File Parameters

The following configuration file parameters affect checks for this warning class.