C and C++


LANG.STRUCT.SE.CALL : Too Many Side Effects in Function Call

Summary

A function call has arguments with a combined total of two or more side effects.

Properties

Class Name Too Many Side Effects in Function Call
Significance style
Mnemonic LANG.STRUCT.SE.CALL
Categories
JSF++ JSF++:204 A single operation with side-effects shall only be used in certain contexts.
JPL JPL:19 Do not use expressions with side effects.
Availability Available for C and C++.
Enabling Checks for this warning class are disabled by default, and require the unnormalized C ASTs for the project. To enable them, add the following WARNING_FILTER rule and RETAIN_UNNORMALIZED_C_AST specification to the project configuration file.
RETAIN_UNNORMALIZED_C_AST = Yes
WARNING_FILTER += allow class="Too Many Side Effects in Function Call"
Note that retaining the unnormalized ASTs will increase the disk space used to store the project representation, and may make the analysis take longer.

Example

extern int x, y;
extern int f(int);            /* Functions are assumed to have side effects unless
                               * SIDE_EFFECT_FREE_FUNCTIONS specifies otherwise */
extern int g(int, int);

void too_many_side_effects_call(void){
    f(x*=2);                                           /* only one side effect */
    g(f(y), x);                                        /* only one side effect */
    g(x+=2, y+=4);  /* 'Too Many Side Effects in Function Call' warning issued here
                     * - 2 side effects */
    g(x, y=(x+=5)); /* 'Too Many Side Effects in Function Call' warning issued here
                     * - 2 side effects */
}

Relevant Configuration File Parameters

The following configuration file parameters affect checks for this warning class.