C and C++


LANG.STRUCT.SE.ECOND : Too Many Side Effects in Condition

Summary

A condition has two or more side effects.

See also Condition Contains Side Effects.

Properties

Class Name Too Many Side Effects in Condition
Significance style
Mnemonic LANG.STRUCT.SE.ECOND
Categories
JSF++ JSF++:204 A single operation with side-effects shall only be used in certain contexts.
JPL JPL:19 Do not use expressions with side effects.
Availability Available for C and C++.
Enabling Checks for this warning class are disabled by default, and require the unnormalized C ASTs for the project. To enable them, add the following WARNING_FILTER rule and RETAIN_UNNORMALIZED_C_AST specification to the project configuration file.
RETAIN_UNNORMALIZED_C_AST = Yes
WARNING_FILTER += allow class="Too Many Side Effects in Condition"
Note that retaining the unnormalized ASTs will increase the disk space used to store the project representation, and may make the analysis take longer.

Example

extern int x, y;
extern int f(int); /* Functions are assumed to have side effects unless
                    * SIDE_EFFECT_FREE_FUNCTIONS specifies otherwise */

int too_many_side_effects_if_condition(void) {
    if (f(x) == 0)                                    /* only one side effect */
        return 1;
    if (f(y) == (x-=2))       /* 'Too Many Side Effects in Condition' warning issued here */
        return 2;
    return 3;
}

void too_many_side_effects_loop_condition(void) {
    while (f(x) == 0)                                 /* only one side effect */
        x++;
    do {
        y++;
    } while (f(y) == (x-=2)); /* 'Too Many Side Effects in Condition' warning issued here */
}

Relevant Configuration File Parameters

The following configuration file parameters affect checks for this warning class.