C and C++


LANG.STRUCT.SW.MB : Missing break

Summary

A switch clause does not end with a break statement.

This class is a strict subset of Malformed switch Statement.

If a switch statement exhibits multiple issues from the following list, the analysis may report only a subset of them.

Properties

Class Name Missing break
Significance style
Mnemonic LANG.STRUCT.SW.MB
Categories
MisraC2023 MisraC2023:16.3 An unconditional break statement shall terminate every switch-clause
Misra2012 Misra2012:16.3 An unconditional break statement shall terminate every switch-clause
Misra2004 Misra2004:15.2 An unconditional break statement shall terminate every non-empty switch clause
AUTOSARC++14 AUTOSARC++14:M6-4-5 An unconditional throw or break statement shall terminate every non-empty switch-clause.
MisraC++2008 MisraC++2008:6-4-5 An unconditional throw or break statement shall terminate every non-empty switch-clause.
MisraC++2023 MisraC++2023:9.4.2 The structure of a switch statement shall be appropriate
CWE CWE:484 Omitted Break Statement in Switch
CERT-C CERT-C:MSC17-C Finish every set of statements associated with a case label with a break statement
JSF++ JSF++:193 Every non-empty case clause in a switch statement shall be terminated with a break statement.
Availability Available for C and C++.
Enabling Checks for this warning class are disabled by default, and require the unnormalized C ASTs for the project. To enable them, add the following WARNING_FILTER rule and RETAIN_UNNORMALIZED_C_AST specification to the project configuration file.
RETAIN_UNNORMALIZED_C_AST = Yes
WARNING_FILTER += allow class="Missing break"
Note that retaining the unnormalized ASTs will increase the disk space used to store the project representation, and may make the analysis take longer.

Example

int lang_struct_sw_mb(int i){
    int a = i;
    switch (a){                           /* all clauses end with break statement */
        case 1: {/*...*/ break;}
        case 2: {/*...*/ a++; break;}
        default: {/*...*/ break;}
    }  

    switch (a){
        case 1:
          a++;                            /* break statement missing at end of this clause */
        case 3:  {      /* 'Missing break' warning issued here:
                         * the previous clause does not end with a break statement, so
                         * execution will fall through into this one.
                         */
          a++;
          break;
        }
        default:
          a--;          /* 'Missing break' warning issued here:
                         * there is no break statement at the end of this clause, which is
                         * the final clause in the switch statement.
                         */
    }

    return a;
}

Relevant Configuration File Parameters

The following configuration file parameters affect checks for this warning class.