C#


CSHARP.COMPARE.CTO.NONCOMP : compareTo in Non-Comparable Class (C#)

要旨

CompareTo() is defined in a class that is not an instance of System.IComparable.

A class C that implements the raw interface System.IComparable must implement the CompareTo(Object) method. If C is made to implement the non-raw interface System.IComparable<C>, then it must implement the CompareTo(C) method instead.

Moreover, it is good practice to make CompareTo() consistent with Equals(): if the comparison of two objects yields 0, then they should be equal. The validity of this implication is in general undecidable. There are, however, frequent situations when, typically, this implication does not hold. An example is when Equals() is inherited from System.Object.

This checker verifies that CompareTo(Object) is defined for classes implementing the raw System.IComparable interface, instead of the (possibly more logical) method CompareTo(C). Moreover, it verifies the consistency of CompareTo() wrt Equals().

Inconsistent definitions of CompareTo()/Equals() induce unexpected behaviors when objects are put inside most sorted collection classes of the standard .NET library.

プロパティ

クラス名 compareTo in Non-Comparable Class (C#)
日本語クラス名 compareTo in Non-Comparable Class (C#)
クラス分類 信頼性 (reliability)
ニーモニック CSHARP.COMPARE.CTO.NONCOMP
カテゴリー
CWE CWE:1076 Insufficient Adherence to Expected Conventions
対応言語 C# で利用可能です。
有効/無効設定 このワーニングクラスのチェックはデフォルトで有効になっています。チェックを無効にするにはプロジェクト設定ファイル (configuration file)に以下の WARNING_FILTER ルールを追加してください。
WARNING_FILTER += discard class="compareTo in Non-Comparable Class (C#)"

  public class MyClass
    {

        public int CompareTo(object obj) // "compareTo in Non-Comparable Class (C#)" warning issued here
        {
            //...

            return 0;

            //...
        }
        
         //...
    }

In this example, the programmer should rewrite the code as follows.

  public class MyClass : System.IComparable
    {

        public int CompareTo(object obj)
        {
            //...

            return 0;

            //...
        }
        
         //...
    }
}

解決法

Use the non-raw interface System.IComparable<C>; make Equals() consistent with CompareTo(). In most cases, this just amounts to providing the missing definition of Equals().

関連のある設定ファイルパラメータ

設定ファイルの以下のパラメータがこのワーニングクラスのチェックに影響します。