CSHARP.HARDCODED.PASSWD : Hardcoded Password (C#)

Password manipulation can be risky, for instance if passwords are stored in plain in a property file. Moreover, passwords stored as program constants expose to the risk of inferring the password by simply looking at the binary executable of the code. This checker identifies situations when password manipulation is done in an unsafe way.

プロパティ

例

Example 1

using System;
using System.Net;


namespace DocumentationExamples
{

    public class Passwords
    {
        private static void Main(string[] args)
        { }

       private static readonly string pwd = "password";
        public void Test()
        {
            string s = "password";
            Environment.GetEnvironmentVariable("password");                                                  // Password in Property File (C#) warning issued here
            Environment.GetEnvironmentVariable(pwd);                                                         // Password in Property File (C#) warning issued here
            Environment.GetEnvironmentVariable(s);                                                           // Password in Property File (C#) warning issued here
            Environment.GetEnvironmentVariable("www.juliasoft.password");                                    // Password in Property File (C#) warning issued here
            Environment.GetEnvironmentVariable("password", EnvironmentVariableTarget.Machine);               // Password in Property File (C#) warning issued here
            Environment.GetEnvironmentVariable("www.juliasoft.password", EnvironmentVariableTarget.Process); // Password in Property File (C#) warning issued here
            Environment.SetEnvironmentVariable("com.julia.password", "goofy mouse");                         // Hardcoded Password (C#) warning issued here
            Environment.SetEnvironmentVariable("com.julia.password", s);                                     // Hardcoded Password (C#) warning issued here
            Environment.SetEnvironmentVariable("com.julia.password", s + " and " + pwd);
            NetworkCredential nc = new NetworkCredential("www.juliasoft.com", "silvio");                     // Hardcoded Password (C#) warning issued here
        }
    }
}

Example 2

public PasswordPropagation
{

    public void CheckPassword(string password)
    {
    
        if (password.Trim().Equals("SpidermanIsTheBest")) // "Hardcoded Password (C#)" warning issued here
        {
            Console.WriteLine("Hi Peter!");
            SavePassword(password.Trim());
        }
                    
                
        if (password.Substring(1).Equals("BlackPearl"))   // "Hardcoded Password (C#)" warning issued here
        {
            Console.WriteLine("Hi Jack!");
            SavePassword(password.Substring(1));
        }
    
    }

    private void SavePassword(string v)
    {
        // ...
    }
}

解決法

Avoid storing passwords in property files and use encrypted files instead. Do not use program constants for passwords, store them in encrypted files instead.

関連のある設定ファイルパラメータ

設定ファイルの以下のパラメータがこのワーニングクラスのチェックに影響します。